@wjones127

It looks like check_versions.py is still broken.

I notice it only seems to be looking at the minor/patch versions when looking at the latest release:

    latest_release = repo.get_latest_release()
    last_version = parse_version(latest_release.tag_name[1:])

However, when looking at the current code it seems to be using major/minor/patch. Is this correct or am I missing something?

    new_version = parse_version(get_versions())

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (fe2d874) to head (931a21e).

@@            Coverage Diff             @@
##             main    #2332      +/-   ##
==========================================
+ Coverage   80.64%   80.66%   +0.02%     
==========================================
  Files         192      192              
  Lines       56684    56684              
  Branches    56684    56684              
==========================================
+ Hits        45713    45725      +12     
+ Misses       8404     8394      -10     
+ Partials     2567     2565       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I notice it only seems to be looking at the minor/patch versions when looking at the latest release:

The [1:] is chopping the v off of the tag. Though not sure if that's what you are talking about here.

This is very weird. Maybe actions/checkout@v2 needs to be updated to actions/checkout@v4? I wonder if it's checking out the wrong branch somehow.

The [1:] is chopping the v off of the tag. Though not sure if that's what you are talking about here.

Ah, in my brain I was thinking it was already split at this point. You're right that chopping off the v should be safe.

@wjones127 because the action was run as pull_request_target it does not run in the context of the PR but rather in the context of the main branch. So the latest version was appearing as 0.10 even though this PR bumps it to 0.11.

Since the PR doesn't need access to any secrets I went ahead and changed it to pull_request.

However, another way we could fix this is to change the action to specify the SHA to checkout manually: actions/checkout#518 (comment)

This should be safe since we aren't actually executing any code in the checked out repo, only looking at the version files.

Let me know if you have a preference for one approach over the other.